Browse Source

where-do-we-go: change files naming & fix test (replace deprecated waitFor method and get the width and height of the window)

pull/761/head
Marie Malarme 3 years ago committed by Clément
parent
commit
22a2add3fc
  1. 12
      dom/where-do-we-go_test.js
  2. 12
      subjects/where-do-we-go/README.md
  3. 0
      subjects/where-do-we-go/where-do-we-go.data.js
  4. 0
      subjects/where-do-we-go/where-do-we-go.html
  5. 0
      subjects/where-do-we-go/where-do-we-go_images/almeria.jpg
  6. 0
      subjects/where-do-we-go/where-do-we-go_images/arlit.jpg
  7. 0
      subjects/where-do-we-go/where-do-we-go_images/atlanta.jpg
  8. 0
      subjects/where-do-we-go/where-do-we-go_images/black-rock-desert.jpg
  9. 0
      subjects/where-do-we-go/where-do-we-go_images/cordoba.jpg
  10. 0
      subjects/where-do-we-go/where-do-we-go_images/georgetown.jpg
  11. 0
      subjects/where-do-we-go/where-do-we-go_images/killeen.jpg
  12. 0
      subjects/where-do-we-go/where-do-we-go_images/lisse.jpg
  13. 0
      subjects/where-do-we-go/where-do-we-go_images/los-caracoles-pass.jpg
  14. 0
      subjects/where-do-we-go/where-do-we-go_images/marrakesh.jpg
  15. 0
      subjects/where-do-we-go/where-do-we-go_images/moab.jpg
  16. 0
      subjects/where-do-we-go/where-do-we-go_images/mount-fuji.jpg
  17. 0
      subjects/where-do-we-go/where-do-we-go_images/namib-desert.jpg
  18. 0
      subjects/where-do-we-go/where-do-we-go_images/newark.jpg
  19. 0
      subjects/where-do-we-go/where-do-we-go_images/nishinoshima-island.jpg
  20. 0
      subjects/where-do-we-go/where-do-we-go_images/qinhuangdao.jpg
  21. 0
      subjects/where-do-we-go/where-do-we-go_images/rio-de-janeiro.jpg
  22. 0
      subjects/where-do-we-go/where-do-we-go_images/shadegan-lagoon.jpg
  23. 0
      subjects/where-do-we-go/where-do-we-go_images/skafta-river.jpg
  24. 0
      subjects/where-do-we-go/where-do-we-go_images/tucson.jpg
  25. 0
      subjects/where-do-we-go/where-do-we-go_images/yuanyang-county.jpg

12
dom/where-do-we-go_test.js

@ -1,4 +1,4 @@
import { places } from './subjects/where-do-we-go/data.js'
import { places } from './subjects/where-do-we-go/where-do-we-go.data.js'
export const tests = []
@ -39,8 +39,8 @@ const dataNames = sortedPlaces.map(({ name }) =>
tests.push(async ({ page, eq }) => {
const { width, height } = await page.evaluate(() => ({
width: document.documentElement.clientWidth,
height: document.documentElement.clientHeight,
width: window.innerWidth,
height: window.innerHeight,
}))
const sections = await page.$$eval('section', sections =>
@ -82,7 +82,7 @@ tests.push(async ({ page, eq }) => {
window.scrollBy(0, window.innerHeight + 200)
})
await page.waitFor(150)
await page.waitForTimeout(150)
const location = await page.$eval('.location', location => [
...location.textContent.split('\n'),
@ -109,7 +109,7 @@ tests.push(async ({ page, eq, getDirection }) => {
window.scrollBy(0, window.innerHeight)
})
await page.waitFor(100)
await page.waitForTimeout(100)
const direction = (await getDirection()).includes('S')
? 'S'
@ -125,7 +125,7 @@ tests.push(async ({ page, eq, getDirection }) => {
window.scrollBy(0, -100)
})
await page.waitFor(100)
await page.waitForTimeout(100)
const direction = (await getDirection()).includes('N')
? 'N'

12
subjects/where-do-we-go/README.md

@ -7,7 +7,7 @@ Tired of staying home for too long, you decide to develop a page to index ideas
Write the function `explore` which creates a page displaying the list of `places` provided in the data file below:
- sort the `places` from the Northest to the Southest
- display a fullscreen-size `<section>` for each place ; use the pics hosted in the `./images` folder to set the `background` attribute with the corresponding image URL. The URL has to be formatted like so: `./images/name-of-the-place.jpg` ; you can see [here](https://github.com/01-edu/public/tree/master/subjects/where-do-we-go/images) the list of images that the folder contains
- display a fullscreen-size `<section>` for each place ; use the pics hosted in the `./where-do-we-go_images` folder (find the download link below) to set the `background` attribute with the corresponding image URL. The URL has to be formatted like so: `./where-do-we-go_images/name-of-the-place.jpg`
- display a location indicator as a `<a>` tag in the middle of the screen which:
- has the class `location`
- displays as text strings separated by `\n`, the `name` and the `coordinates` of the current place featured in the image
@ -22,16 +22,18 @@ Write the function `explore` which creates a page displaying the list of `places
- [`window`](https://developer.mozilla.org/en-US/docs/Web/API/Window): [`innerHeight`](https://developer.mozilla.org/en-US/docs/Web/API/Window/innerHeight), [`scrollY`](https://developer.mozilla.org/en-US/docs/Web/API/Window/scrollY), [`pageYOffset`](https://developer.mozilla.org/en-US/docs/Web/API/Window/pageYOffset)
- Take a look at the [DMS coordinates system](https://en.wikipedia.org/wiki/Decimal_degrees)
### Provided files
### Files
You have at your disposal the following files that you can download to test locally:
You only need to create & submit the JS file `where-do-we-go.js` ; we're providing you the following files to download (click right and save link) & test locally:
- the HTML file [index.html](/public/subjects/where-do-we-go/index.html) to open in the browser, which includes:
- the HTML file [where-do-we-go.html](/public/subjects/where-do-we-go/where-do-we-go.html) to open in the browser, which includes:
- the JS script which will allow to run your code
- some CSS pre-styled classes: feel free to use those as they are, or modify them
- the data file [data.js](/public/subjects/where-do-we-go/data.js) from which you can import `places`
- the data file [where-do-we-go.data.js](/public/subjects/where-do-we-go/where-do-we-go.data.js) from which you can import `places`
- the images to use, in this [compressed folder](https://assets.01-edu.org/where-do-we-go_images.zip)
### Expected result

0
subjects/where-do-we-go/data.js → subjects/where-do-we-go/where-do-we-go.data.js

0
subjects/where-do-we-go/index.html → subjects/where-do-we-go/where-do-we-go.html

0
subjects/where-do-we-go/images/almeria.jpg → subjects/where-do-we-go/where-do-we-go_images/almeria.jpg

Before

Width:  |  Height:  |  Size: 206 KiB

After

Width:  |  Height:  |  Size: 206 KiB

0
subjects/where-do-we-go/images/arlit.jpg → subjects/where-do-we-go/where-do-we-go_images/arlit.jpg

Before

Width:  |  Height:  |  Size: 155 KiB

After

Width:  |  Height:  |  Size: 155 KiB

0
subjects/where-do-we-go/images/atlanta.jpg → subjects/where-do-we-go/where-do-we-go_images/atlanta.jpg

Before

Width:  |  Height:  |  Size: 218 KiB

After

Width:  |  Height:  |  Size: 218 KiB

0
subjects/where-do-we-go/images/black-rock-desert.jpg → subjects/where-do-we-go/where-do-we-go_images/black-rock-desert.jpg

Before

Width:  |  Height:  |  Size: 244 KiB

After

Width:  |  Height:  |  Size: 244 KiB

0
subjects/where-do-we-go/images/cordoba.jpg → subjects/where-do-we-go/where-do-we-go_images/cordoba.jpg

Before

Width:  |  Height:  |  Size: 610 KiB

After

Width:  |  Height:  |  Size: 610 KiB

0
subjects/where-do-we-go/images/georgetown.jpg → subjects/where-do-we-go/where-do-we-go_images/georgetown.jpg

Before

Width:  |  Height:  |  Size: 248 KiB

After

Width:  |  Height:  |  Size: 248 KiB

0
subjects/where-do-we-go/images/killeen.jpg → subjects/where-do-we-go/where-do-we-go_images/killeen.jpg

Before

Width:  |  Height:  |  Size: 296 KiB

After

Width:  |  Height:  |  Size: 296 KiB

0
subjects/where-do-we-go/images/lisse.jpg → subjects/where-do-we-go/where-do-we-go_images/lisse.jpg

Before

Width:  |  Height:  |  Size: 166 KiB

After

Width:  |  Height:  |  Size: 166 KiB

0
subjects/where-do-we-go/images/los-caracoles-pass.jpg → subjects/where-do-we-go/where-do-we-go_images/los-caracoles-pass.jpg

Before

Width:  |  Height:  |  Size: 209 KiB

After

Width:  |  Height:  |  Size: 209 KiB

0
subjects/where-do-we-go/images/marrakesh.jpg → subjects/where-do-we-go/where-do-we-go_images/marrakesh.jpg

Before

Width:  |  Height:  |  Size: 444 KiB

After

Width:  |  Height:  |  Size: 444 KiB

0
subjects/where-do-we-go/images/moab.jpg → subjects/where-do-we-go/where-do-we-go_images/moab.jpg

Before

Width:  |  Height:  |  Size: 223 KiB

After

Width:  |  Height:  |  Size: 223 KiB

0
subjects/where-do-we-go/images/mount-fuji.jpg → subjects/where-do-we-go/where-do-we-go_images/mount-fuji.jpg

Before

Width:  |  Height:  |  Size: 133 KiB

After

Width:  |  Height:  |  Size: 133 KiB

0
subjects/where-do-we-go/images/namib-desert.jpg → subjects/where-do-we-go/where-do-we-go_images/namib-desert.jpg

Before

Width:  |  Height:  |  Size: 164 KiB

After

Width:  |  Height:  |  Size: 164 KiB

0
subjects/where-do-we-go/images/newark.jpg → subjects/where-do-we-go/where-do-we-go_images/newark.jpg

Before

Width:  |  Height:  |  Size: 227 KiB

After

Width:  |  Height:  |  Size: 227 KiB

0
subjects/where-do-we-go/images/nishinoshima-island.jpg → subjects/where-do-we-go/where-do-we-go_images/nishinoshima-island.jpg

Before

Width:  |  Height:  |  Size: 222 KiB

After

Width:  |  Height:  |  Size: 222 KiB

0
subjects/where-do-we-go/images/qinhuangdao.jpg → subjects/where-do-we-go/where-do-we-go_images/qinhuangdao.jpg

Before

Width:  |  Height:  |  Size: 126 KiB

After

Width:  |  Height:  |  Size: 126 KiB

0
subjects/where-do-we-go/images/rio-de-janeiro.jpg → subjects/where-do-we-go/where-do-we-go_images/rio-de-janeiro.jpg

Before

Width:  |  Height:  |  Size: 282 KiB

After

Width:  |  Height:  |  Size: 282 KiB

0
subjects/where-do-we-go/images/shadegan-lagoon.jpg → subjects/where-do-we-go/where-do-we-go_images/shadegan-lagoon.jpg

Before

Width:  |  Height:  |  Size: 78 KiB

After

Width:  |  Height:  |  Size: 78 KiB

0
subjects/where-do-we-go/images/skafta-river.jpg → subjects/where-do-we-go/where-do-we-go_images/skafta-river.jpg

Before

Width:  |  Height:  |  Size: 163 KiB

After

Width:  |  Height:  |  Size: 163 KiB

0
subjects/where-do-we-go/images/tucson.jpg → subjects/where-do-we-go/where-do-we-go_images/tucson.jpg

Before

Width:  |  Height:  |  Size: 168 KiB

After

Width:  |  Height:  |  Size: 168 KiB

0
subjects/where-do-we-go/images/yuanyang-county.jpg → subjects/where-do-we-go/where-do-we-go_images/yuanyang-county.jpg

Before

Width:  |  Height:  |  Size: 197 KiB

After

Width:  |  Height:  |  Size: 197 KiB

Loading…
Cancel
Save